Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686973002: Dart2js CPS: Implement 'await for'. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)
Modified:
4 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dart2js CPS: Implement 'await for'. The implementation strategy is in terms of a loop over a StreamIterator, similar to what is done in the dart2js SSA backend and in the Dart VM. BUG=https://github.com/dart-lang/sdk/issues/24984 R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/35839c784003fbfba689c29bd0f95aae2253d211

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review comments. #

Patch Set 3 : Not all for-in local variables are declared in the for-in. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -22 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 1 chunk +99 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
4 years, 10 months ago (2016-02-10 12:46:10 UTC) #2
asgerf
LGTM. https://codereview.chromium.org/1686973002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1686973002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1157 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1157: } Instead of visiting the declaration, I think ...
4 years, 10 months ago (2016-02-10 13:03:27 UTC) #3
Kevin Millikin (Google)
https://codereview.chromium.org/1686973002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1686973002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1157 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1157: } On 2016/02/10 13:03:27, asgerf wrote: > Instead of ...
4 years, 10 months ago (2016-02-10 13:27:41 UTC) #4
Kevin Millikin (Google)
4 years, 10 months ago (2016-02-10 14:28:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
35839c784003fbfba689c29bd0f95aae2253d211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698