third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1686953006: Revert of Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1686953006: Revert of Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index e8d7548e799de7f10b29066d0def91d439afd7e3..d52c89cb03a857138134ec340e5f067479e41078 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -208,7 +208,7 @@

, m_lengthDownloadedToFile(0)

, m_receivedLength(0)

, m_exceptionCode(0)

- , m_progressEventThrottle(ProgressEventThrottle::create(this))

+ , m_progressEventThrottle(XMLHttpRequestProgressEventThrottle::create(this))

, m_responseTypeCode(ResponseTypeDefault)

, m_isolatedWorldSecurityOrigin(isolatedWorldSecurityOrigin)

, m_eventDispatchRecursionLevel(0)

@@ -506,12 +506,12 @@

ScopedEventDispatchProtect protect(&m_eventDispatchRecursionLevel);

if (m_async || (m_state <= OPENED || m_state == DONE)) {

TRACE_EVENT1("devtools.timeline", "XHRReadyStateChange", "data", InspectorXhrReadyStateChangeEvent::data(executionContext(), this));

- ProgressEventThrottle::DeferredEventAction action = ProgressEventThrottle::Ignore;

+ XMLHttpRequestProgressEventThrottle::DeferredEventAction action = XMLHttpRequestProgressEventThrottle::Ignore;

if (m_state == DONE) {

if (m_error)

- action = ProgressEventThrottle::Clear;

+ action = XMLHttpRequestProgressEventThrottle::Clear;

else

- action = ProgressEventThrottle::Flush;

+ action = XMLHttpRequestProgressEventThrottle::Flush;

}

m_progressEventThrottle->dispatchReadyStateChangeEvent(Event::create(EventTypeNames::readystatechange), action);

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data", InspectorUpdateCountersEvent::data());