Remove uses of base/lazy_instance

Remove uses of base/lazy_instance

Now that we rely on threadsafe initialization we can stop using
base::LazyInstance to perform threadsafe initialization of function
level statics.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1308cd12434c9536a28592ff09399a57ef7f4f77

[jamesr, 2016-02-10 21:28:38]

jamesr@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[jamesr, 2016-02-10 21:28:39]

https://codereview.chromium.org/1686953003/diff/1/mojo/message_pump/message_p...
File mojo/message_pump/message_pump_mojo.cc (right):

https://codereview.chromium.org/1686953003/diff/1/mojo/message_pump/message_p...
mojo/message_pump/message_pump_mojo.cc:118: RunState* old_state = nullptr;
drive-by s/NULL/nullptr/g since there was a NULL in one of the lines i had to
modify

https://codereview.chromium.org/1686953003/diff/1/shell/context.cc
File shell/context.cc (right):

https://codereview.chromium.org/1686953003/diff/1/shell/context.cc#newcode246
shell/context.cc:246: std::ignore = initialized;
arguably this is too fancy, especially since it comes from <tuple>.  if you
don't like it i can do "static_cast<void>(initialized);" here instead. there's a
debate about this very thing on the internal c++ style list

[viettrungluu, 2016-02-10 23:55:50]

lgtm otherwise

https://codereview.chromium.org/1686953003/diff/1/shell/context.cc
File shell/context.cc (right):

https://codereview.chromium.org/1686953003/diff/1/shell/context.cc#newcode246
shell/context.cc:246: std::ignore = initialized;
On 2016/02/10 21:28:39, jamesr wrote:
> arguably this is too fancy, especially since it comes from <tuple>.  if you
> don't like it i can do "static_cast<void>(initialized);" here instead. there's
a
> debate about this very thing on the internal c++ style list

Should probably use MOJO_ALLOW_UNUSED_LOCAL from mojo/public/c/system/macros.h.

Or maybe for consistency, ALLOW_UNUSED_LOCAL from base/compiler_specific.h.

[jamesr, 2016-02-11 06:33:49]

The macro's longer than either of the standard C++ ways of doing this, which is
kind of sad.  If the technique really was compiler-specific I could see the use
but it isn't even in chromium's base (??)

[jamesr, 2016-02-29 21:51:37]

Description was changed from

==========
Remove uses of base/lazy_instance

Now that we rely on threadsafe initialization we can stop using
base::LazyInstance to perform threadsafe initialization of function
level statics.
==========

to

==========
Remove uses of base/lazy_instance

Now that we rely on threadsafe initialization we can stop using
base::LazyInstance to perform threadsafe initialization of function
level statics.

R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/1308cd12434c9536a28592ff093...
==========

[jamesr, 2016-02-29 21:51:38]

Committed patchset #1 (id:1) manually as
1308cd12434c9536a28592ff09399a57ef7f4f77 (presubmit successful).