Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1686893003: Reland of Oilpan: Remove page navigation GCs from the prologues of V8's GCs (Closed)

Created:
4 years, 10 months ago by waffles
Modified:
4 years, 10 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Oilpan: Remove page navigation GCs from the prologues of V8's GCs (patchset #1 id:1 of https://codereview.chromium.org/1688483002/ ) Reason for revert: Test is disabled, reverting the revert. Original issue's description: > Revert of Oilpan: Remove page navigation GCs from the prologues of V8's GCs (patchset #1 id:1 of https://codereview.chromium.org/1679683003/ ) > > Reason for revert: > Speculative revert to fix a Mac browser test that relies on 'loadstop' being transmitted in certain contexts. > > Original issue's description: > > Oilpan: Remove page navigation GCs from the prologues of V8's GCs > > > > I've removed synchronous Oilpan's GCs from the epilogues of V8's major GCs > > but it didn't fix the regression of v8_gc_total metrics caused by Oilpan's shipping. > > > > This CL tries to remove page navigation GCs from the prologues of V8's GCs. > > I confirmed that this doesn't cause regression in memory.top_7_stress. > > > > BUG=582831 > > > > Committed: https://crrev.com/00a90c6253df77840fcf2a638cfa4346a71479be > > Cr-Commit-Position: refs/heads/master@{#374395} > > TBR=sigbjornf@opera.com,haraken@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=582831 > > Committed: https://crrev.com/328df273bffd0dbd30c3ecd681a4249be9020825 > Cr-Commit-Position: refs/heads/master@{#374464} TBR=sigbjornf@opera.com,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582831 Committed: https://crrev.com/3501f840dc01a9f96a5b7442b2ef9abe842eaf74 Cr-Commit-Position: refs/heads/master@{#374569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
waffles
Created Reland of Oilpan: Remove page navigation GCs from the prologues of V8's GCs
4 years, 10 months ago (2016-02-10 01:40:03 UTC) #1
haraken
Thanks, LGTM
4 years, 10 months ago (2016-02-10 01:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686893003/1
4 years, 10 months ago (2016-02-10 01:46:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 01:49:53 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 01:50:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3501f840dc01a9f96a5b7442b2ef9abe842eaf74
Cr-Commit-Position: refs/heads/master@{#374569}

Powered by Google App Engine
This is Rietveld 408576698