Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1686833002: Add knowledge about blocking and passive event listeners. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
aelias_OOO_until_Jul13, blink-reviews, blink-reviews-api_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add knowledge about blocking and passive event listeners. Originally we though we could just get away with assuming blocking represented blocking and passive. But it is the case when there are touch event listeners that aren't hit we must fire touch events to the main thread which aren't really necessarily. Change this to be an enumeration of kBlockingAndPassive. BUG=489802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369 Cr-Commit-Position: refs/heads/master@{#375054}

Patch Set 1 #

Patch Set 2 : Fix unit test #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Fix typo #

Messages

Total messages: 14 (8 generated)
dtapuska
On 2016/02/10 13:28:06, dtapuska wrote: > mailto:dtapuska@chromium.org changed reviewers: > + mailto:enne@chromium.org @enne; normally would ...
4 years, 10 months ago (2016-02-10 13:29:35 UTC) #4
aelias_OOO_until_Jul13
lgtm, still needs Source/core OWNERS though. https://codereview.chromium.org/1686833002/diff/40001/third_party/WebKit/public/platform/WebEventListenerProperties.h File third_party/WebKit/public/platform/WebEventListenerProperties.h (right): https://codereview.chromium.org/1686833002/diff/40001/third_party/WebKit/public/platform/WebEventListenerProperties.h#newcode20 third_party/WebKit/public/platform/WebEventListenerProperties.h:20: Passive, // This ...
4 years, 10 months ago (2016-02-10 20:33:47 UTC) #6
enne (OOO)
lgtm, sorry!
4 years, 10 months ago (2016-02-11 19:28:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686833002/60001
4 years, 10 months ago (2016-02-11 20:20:52 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-12 00:15:39 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:39:52 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/364349a3c0f701a0397ef5ffaaf948ad037fb369
Cr-Commit-Position: refs/heads/master@{#375054}

Powered by Google App Engine
This is Rietveld 408576698