Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1686803003: move compose-shader into base-class as factory (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move compose-shader into base-class as factory next steps: 1. this lands 2. update android to call the new factory 3. move SkComposeShader.h into private BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686803003 Committed: https://skia.googlesource.com/skia/+/a2b340f8a8d5f219eb62f5f9b654cf19c988c578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M include/core/SkShader.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
reed1
4 years, 10 months ago (2016-02-09 22:03:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686803003/1
4 years, 10 months ago (2016-02-09 22:03:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 22:36:42 UTC) #8
reed1
4 years, 10 months ago (2016-02-10 16:47:53 UTC) #9
f(malita)
lgtm
4 years, 10 months ago (2016-02-10 16:52:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686803003/1
4 years, 10 months ago (2016-02-10 16:52:41 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:53:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a2b340f8a8d5f219eb62f5f9b654cf19c988c578

Powered by Google App Engine
This is Rietveld 408576698