Precompilation: drop unused types and type arguments and empty classes and libraries.

Precompilation: drop unused types and type arguments and empty classes and libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
precompiled flutter asteriods arm64 8926398 -> 8782136 (-1.6%)

R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b112c6d25fa714ad1fa4060a3d4bc4cc40c54eb

[rmacnak, 2016-02-09 23:22:35]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 18824154 -> 18723339 (-0.53%)
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 18824154 -> 18723339 (-0.53%)

BUG=
==========

[rmacnak, 2016-02-17 01:51:48]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 18824154 -> 18723339 (-0.53%)

BUG=
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 22786177 -> 22736262 (-0.2%)
==========

[rmacnak, 2016-02-17 20:16:17]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 22786177 -> 22736262 (-0.2%)
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 22786177 -> 22736262 (-0.2%)

BUG=
==========

[rmacnak, 2016-02-17 20:32:32]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js x64 22786177 -> 22736262 (-0.2%)

BUG=
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
==========

[rmacnak, 2016-02-19 01:42:49]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
precompiled flutter asteriods arm64 8926398 -> 8782136 (-1.6%)
==========

[rmacnak, 2016-02-19 01:44:51]

rmacnak@google.com changed reviewers:
+ regis@google.com

[regis, 2016-02-19 20:54:07]

LGTM with comments

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:565: AddType(type);
I am not sure, but if cls is a typedef, you may also need to add the function
type of its signature function.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:592: AddTypeArguments(vector);
Bad indentation.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:602: }
What about BoundedType and TypeRef?

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:1446: // will only be removed as a consquence of an
entire library being
consequence

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler.h
File runtime/vm/precompiler.h (right):

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.h:181: return key->token_pos().value();
You'll get a lot of collisions, since the first class declaration of a script
will appear at roughly the same token position. I'm not sure whether it matters
or not.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.h:204: return key->token_pos().value();
An AbstractType has a Hash(). You do not use Hash() here, but below for
TypeArguments.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/raw_object_...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1294: // TODO(rmacnak): ASSERT(ptr()->index_
!= static_cast<classid_t>(-1));
Is this ASSERT not yet valid?

[rmacnak, 2016-02-20 01:35:39]

PTAL.

Also tracing the type arguments of const objects.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:565: AddType(type);
On 2016/02/19 20:54:07, regis wrote:
> I am not sure, but if cls is a typedef, you may also need to add the function
> type of its signature function.

Done.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:592: AddTypeArguments(vector);
On 2016/02/19 20:54:07, regis wrote:
> Bad indentation.

Done.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:602: }
On 2016/02/19 20:54:07, regis wrote:
> What about BoundedType and TypeRef?

Added.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/precompiler...
runtime/vm/precompiler.cc:1446: // will only be removed as a consquence of an
entire library being
On 2016/02/19 20:54:07, regis wrote:
> consequence

Done.

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/raw_object_...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1686773002/diff/120001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1294: // TODO(rmacnak): ASSERT(ptr()->index_
!= static_cast<classid_t>(-1));
On 2016/02/19 20:54:07, regis wrote:
> Is this ASSERT not yet valid?

I put it back in locally but forgot to reupload the CL. It passes now. (The last
case was the build-in libraries, which are always referenced from the object
store.)

[regis, 2016-02-22 15:44:03]

LGTM

https://codereview.chromium.org/1686773002/diff/140001/runtime/vm/precompiler.h
File runtime/vm/precompiler.h (right):

https://codereview.chromium.org/1686773002/diff/140001/runtime/vm/precompiler...
runtime/vm/precompiler.h:204: return key->token_pos().value();
So the hash does not work?

[rmacnak, 2016-02-22 22:03:46]

https://codereview.chromium.org/1686773002/diff/140001/runtime/vm/precompiler.h
File runtime/vm/precompiler.h (right):

https://codereview.chromium.org/1686773002/diff/140001/runtime/vm/precompiler...
runtime/vm/precompiler.h:204: return key->token_pos().value();
On 2016/02/22 15:44:03, regis wrote:
> So the hash does not work?

Forgot. Switched to ->Hash().

[rmacnak, 2016-02-22 22:05:08]

Description was changed from

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
precompiled flutter asteriods arm64 8926398 -> 8782136 (-1.6%)
==========

to

==========
Precompilation: drop unused types and type arguments and empty classes and
libraries.

precompiled dart2js arm 20748837 -> 20639848 (-0.52%)
precompiled flutter asteriods arm64 8926398 -> 8782136 (-1.6%)

R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b112c6d25fa714ad1fa4060a3d4bc4cc40c54eb
==========

[rmacnak, 2016-02-22 22:05:10]

Committed patchset #10 (id:180001) manually as
4b112c6d25fa714ad1fa4060a3d4bc4cc40c54eb (presubmit successful).