Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686753003: Revert "Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used on bots)" (Closed)

Created:
4 years, 10 months ago by dsansome
Modified:
4 years, 10 months ago
Reviewers:
agable
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used on bots)" BUG=585632 TBR=agable Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M rietveld.py View 4 chunks +5 lines, -10 lines 0 comments Download
M tests/rietveld_test.py View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsansome
4 years, 10 months ago (2016-02-10 00:05:58 UTC) #2
dsansome
4 years, 10 months ago (2016-02-10 00:06:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686753003/1
4 years, 10 months ago (2016-02-10 00:06:26 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 00:08:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298693

Powered by Google App Engine
This is Rietveld 408576698