build_apprtc_collider.py - Issue 1686753002: Throw away everything in the go workspace except bin (2nd attempt).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_apprtc_collider.py

Issue 1686753002: Throw away everything in the go workspace except bin (2nd attempt). (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_apprtc_collider.py

diff --git a/build_apprtc_collider.py b/build_apprtc_collider.py

index 2758b1f427bf1e97f2317798725a8fbe9c5f4db0..95ae5328acecc0eaa44a1258eec5c737b7166c41 100755

--- a/build_apprtc_collider.py

+++ b/build_apprtc_collider.py

@@ -45,7 +45,8 @@ def main():

go_bin_dir = os.path.join(golang_workspace, 'bin')

tmp_dir = tempfile.mkdtemp()

shutil.move(go_bin_dir, tmp_dir)

- shutil.rmtree(golang_workspace)

+ utils.RemoveDirectory(golang_workspace)

+ os.makedirs(golang_workspace)

phoglund_chromium 2016/02/10 08:01:19 Oops! No, you're right, the move doesn't create di

shutil.move(os.path.join(tmp_dir, 'bin'), go_bin_dir)

os.rmdir(tmp_dir)

« no previous file with comments | « no previous file | no next file » | no next file with comments »