Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686733003: dart2js cps: Update status files. (Closed)

Created:
4 years, 10 months ago by asgerf
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -7 lines 1 comment Download
M tests/language/language_dart2js.status View 3 chunks +5 lines, -2 lines 4 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
TBR https://codereview.chromium.org/1686733003/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (left): https://codereview.chromium.org/1686733003/diff/1/tests/co19/co19-dart2js.status#oldcode9630 tests/co19/co19-dart2js.status:9630: -LibTest/core/Invocation/positionalArguments_A01_t01: RuntimeError # Please triage this failure. These ...
4 years, 10 months ago (2016-02-10 10:20:51 UTC) #2
asgerf
Committed patchset #1 (id:1) manually as 3f8fdc24348f4f9c0399605de9297fdc820e6d75 (presubmit successful).
4 years, 10 months ago (2016-02-10 10:21:17 UTC) #4
Kevin Millikin (Google)
LGTM.
4 years, 10 months ago (2016-02-10 10:24:15 UTC) #5
Kevin Millikin (Google)
https://codereview.chromium.org/1686733003/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/1686733003/diff/1/tests/language/language_dart2js.status#newcode252 tests/language/language_dart2js.status:252: accessor_conflict_export2_test: CompileTimeError # Issue 25747 Actually, this doesn't look ...
4 years, 10 months ago (2016-02-10 10:28:48 UTC) #6
asgerf
4 years, 10 months ago (2016-02-10 10:36:27 UTC) #7
Message was sent while issue was closed. 
This was committed because the build was red.

Comments are addressed in https://codereview.chromium.org/1688693002.

https://codereview.chromium.org/1686733003/diff/1/tests/language/language_dar...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/1686733003/diff/1/tests/language/language_dar...
tests/language/language_dart2js.status:252: accessor_conflict_export2_test:
CompileTimeError # Issue 25747
On 2016/02/10 10:28:48, Kevin Millikin (Google) wrote:
> Actually, this doesn't look quite right.  There is already an expectation for
[
> $compiler == dart2js ] of Crash.  Expectations are the union of all the ones
> that apply, so for $cps_ir we have "CompileTimeError, Crash".
> 
> I'd rather have the expectation for CPS IR be CompileTimeError, which requires
> moving the Crash expectation for this test to the [ $compiler == dart2js &&
> $cps_ir == false ] section.

Done in other CL.

https://codereview.chromium.org/1686733003/diff/1/tests/language/language_dar...
tests/language/language_dart2js.status:253: accessor_conflict_export_test:
CompileTimeError # Issue 25747
On 2016/02/10 10:28:48, Kevin Millikin (Google) wrote:
> Same comment.

Done.

Powered by Google App Engine
This is Rietveld 408576698