Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 168673002: Drop [LegacyImplementedInBaseClass] from ChildNode IDL interface (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken, adamk
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Drop [LegacyImplementedInBaseClass] from ChildNode IDL interface Drop [LegacyImplementedInBaseClass] from ChildNode IDL interface and move the related API from Node to a new ChildNode class. All the callers of Node's previousElementSibling() / nextElementSibling() were already previously updated to use ElementTraversal instead for consistency. R=haraken, adamk BUG=344224 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
A Source/core/dom/ChildNode.h View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Inactive
6 years, 10 months ago (2014-02-15 21:07:48 UTC) #1
haraken
LGTM. Would it be hard to remove all [LegacyImplementedInBaseClass] ?
6 years, 10 months ago (2014-02-16 03:29:19 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-16 03:37:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168673002/1
6 years, 10 months ago (2014-02-16 03:37:49 UTC) #4
Inactive
On 2014/02/16 03:29:19, haraken wrote: > LGTM. > > Would it be hard to remove ...
6 years, 10 months ago (2014-02-16 03:40:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-16 06:55:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12607
6 years, 10 months ago (2014-02-16 06:55:11 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-16 19:21:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168673002/1
6 years, 10 months ago (2014-02-16 19:21:56 UTC) #9
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-16 21:13:23 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-16 21:13:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168673002/1
6 years, 10 months ago (2014-02-16 21:13:44 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 00:13:09 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12633
6 years, 10 months ago (2014-02-17 00:13:09 UTC) #14
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 00:53:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168673002/1
6 years, 10 months ago (2014-02-17 00:53:46 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 00:53:58 UTC) #17
Message was sent while issue was closed.
Change committed as 167249

Powered by Google App Engine
This is Rietveld 408576698