Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1686723002: [Cast,Android,PresentationAPI] Allow sending string app messages vs valid JSON ones. (Closed)

Created:
4 years, 10 months ago by whywhat
Modified:
4 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast,Android,PresentationAPI] Allow sending string app messages vs valid JSON ones. BUG=585538 TEST=manually run e2e tests and tried sending an app message with a string message. Committed: https://crrev.com/3d54d8940ac693a826db2f6220d18f44c1e96dec Cr-Commit-Position: refs/heads/master@{#374644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSession.java View 4 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
whywhat
PTaL!
4 years, 10 months ago (2016-02-09 20:52:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686723002/1
4 years, 10 months ago (2016-02-09 20:55:53 UTC) #4
whywhat
+Zhiqiang who just became a committer a day ago :) With great power comes great ...
4 years, 10 months ago (2016-02-09 21:07:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 21:48:39 UTC) #8
Zhiqiang Zhang (Slow)
lgtm
4 years, 10 months ago (2016-02-10 11:25:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686723002/1
4 years, 10 months ago (2016-02-10 11:56:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 12:01:25 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 12:02:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d54d8940ac693a826db2f6220d18f44c1e96dec
Cr-Commit-Position: refs/heads/master@{#374644}

Powered by Google App Engine
This is Rietveld 408576698