ui/gfx/render_text_win.h - Issue 16867016: Windows implementation of multiline RenderText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_win.h

Issue 16867016: Windows implementation of multiline RenderText (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: comments addressed Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_win.h

diff --git a/ui/gfx/render_text_win.h b/ui/gfx/render_text_win.h

index 620ef092dff98fd2175427ab390b253aa3057198..3fc803c6333629c749c388ac3fbc803e1abfdbfb 100644

--- a/ui/gfx/render_text_win.h

+++ b/ui/gfx/render_text_win.h

@@ -64,6 +64,7 @@ class RenderTextWin : public RenderText {

// Overridden from RenderText:

virtual Size GetStringSize() OVERRIDE;

+ virtual Size GetMultilineTextSize() OVERRIDE;

virtual int GetBaseline() OVERRIDE;

virtual SelectionModel FindCursorPosition(const Point& point) OVERRIDE;

virtual std::vector<FontSpan> GetFontSpansForTesting() OVERRIDE;

@@ -91,6 +92,7 @@ class RenderTextWin : public RenderText {

void ItemizeLogicalText();

void LayoutVisualText();

void LayoutTextRun(internal::TextRun* run);

+ void ComputeLines();

Alexei Svitkine (slow) 2013/08/12 20:42:33 Can you add a 1-line comment? Thanks.

ckocagil 2013/08/13 20:22:28 Done.

// Helper function that calls |ScriptShape()| on the run, which has logic to

// handle E_OUTOFMEMORY return codes.