Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16867015: Revert r207951 - "Separate NaCl switches to their own file." (Closed)

Created:
7 years, 6 months ago by Dirk Pranke
Modified:
7 years, 6 months ago
Reviewers:
yael.aharon, Nico
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Revert r207951 - "Separate NaCl switches to their own file." This change doesn't build under xcode for some reason. See http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/28702 TBR=thakis@chromium.org, yael.aharon@intel.com BUG=244791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -145 lines) Patch
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/breakpad_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/app/nacl_fork_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M chrome/common/nacl_cmd_line.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common_constants.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/nacl/nacl_broker_listener.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/nacl/nacl_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/nacl/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/nacl/common/nacl_switches.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/nacl/common/nacl_switches.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D components/nacl_common.gypi View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Committed patchset #1 manually as r207964 (presubmit successful).
7 years, 6 months ago (2013-06-22 00:01:15 UTC) #1
Dirk Pranke
7 years, 6 months ago (2013-06-22 00:01:42 UTC) #2
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698