chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc - Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

index 3258129f49ca366ff42a88d6cf44726da6aaa603..8f14bac1f534af80e69f775ef8f4de52ee08a490 100644

--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

@@ -132,7 +132,7 @@ void AbortsPageLoadMetricsObserver::OnComplete(

DCHECK(!time_to_abort.is_zero());

// Don't log abort times if the page was backgrounded before the abort event.

- if (!EventOccurredInForeground(time_to_abort, extra_info))

+ if (!StartInForegroundEventInForeground(time_to_abort, extra_info))

return;

if (extra_info.time_to_commit.is_zero()) {