components/page_load_metrics/browser/page_load_metrics_observer.cc - Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/page_load_metrics_observer.h ('k') | components/page_load_metrics/browser/page_load_metrics_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_observer.cc

diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.cc b/components/page_load_metrics/browser/page_load_metrics_observer.cc

index b41c347c1f9a827aa3609efc5a728c753c9cd830..23a00fbaee3f6ce879bf04cf4539156b1f8207ab 100644

--- a/components/page_load_metrics/browser/page_load_metrics_observer.cc

+++ b/components/page_load_metrics/browser/page_load_metrics_observer.cc

@@ -7,13 +7,13 @@

namespace page_load_metrics {

PageLoadExtraInfo::PageLoadExtraInfo(

- const base::TimeDelta& first_background_time,

- const base::TimeDelta& first_foreground_time,

+ base::TimeDelta first_background_time,

+ base::TimeDelta first_foreground_time,

bool started_in_foreground,

const GURL& committed_url,

- const base::TimeDelta& time_to_commit,

+ base::TimeDelta time_to_commit,

UserAbortType abort_type,

- const base::TimeDelta& time_to_abort)

+ base::TimeDelta time_to_abort)

: first_background_time(first_background_time),

first_foreground_time(first_foreground_time),

started_in_foreground(started_in_foreground),