Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 3258129f49ca366ff42a88d6cf44726da6aaa603..4c101f6009c02663d45ae3a1f911a2ca88a14461 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -11,7 +11,7 @@ using page_load_metrics::UserAbortType;
namespace {
void RecordAbortBeforeCommit(UserAbortType abort_type,
- const base::TimeDelta& time_to_abort) {
+ base::TimeDelta time_to_abort) {
switch (abort_type) {
case UserAbortType::ABORT_RELOAD:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortReloadBeforeCommit,
@@ -51,7 +51,7 @@ void RecordAbortBeforeCommit(UserAbortType abort_type,
}
void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type,
- const base::TimeDelta& time_to_abort) {
+ base::TimeDelta time_to_abort) {
switch (abort_type) {
case UserAbortType::ABORT_RELOAD:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortReloadBeforePaint,
@@ -128,11 +128,11 @@ void AbortsPageLoadMetricsObserver::OnComplete(
if (abort_type == UserAbortType::ABORT_NONE)
return;
- const base::TimeDelta& time_to_abort = extra_info.time_to_abort;
+ base::TimeDelta time_to_abort = extra_info.time_to_abort;
DCHECK(!time_to_abort.is_zero());
// Don't log abort times if the page was backgrounded before the abort event.
- if (!EventOccurredInForeground(time_to_abort, extra_info))
+ if (!WasStartedInForegroundEventInForeground(time_to_abort, extra_info))
return;
if (extra_info.time_to_commit.is_zero()) {

Powered by Google App Engine
This is Rietveld 408576698