Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h
index 0d74e2d6a319c621653b7ed491d8095dbdfbc4f6..2496a59c44a017cc284075f42893f746048812bc 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.h
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h
@@ -51,22 +51,20 @@ enum UserAbortType {
};
struct PageLoadExtraInfo {
- PageLoadExtraInfo(const base::TimeDelta& first_background_time,
- const base::TimeDelta& first_foreground_time,
+ PageLoadExtraInfo(base::TimeDelta first_background_time,
+ base::TimeDelta first_foreground_time,
bool started_in_foreground,
const GURL& committed_url,
const base::TimeDelta& time_to_commit,
UserAbortType abort_type,
const base::TimeDelta& time_to_abort);
- // Returns the time to first background if the page load started in the
- // foreground. If the page has not been backgrounded, or the page started in
- // the background, this will be base::TimeDelta().
+ // The first time that the page was backgrounded since the navigation started.
+ // If the page has not been backgrounded this will be base::TimeDelta().
const base::TimeDelta first_background_time;
- // Returns the time to first foreground if the page load started in the
- // background. If the page has not been foregrounded, or the page started in
- // the foreground, this will be base::TimeDelta().
+ // The first time that the page was foregrounded since the navigation started.
+ // If the page has not been foregrounded this will be base::TimeDelta().
const base::TimeDelta first_foreground_time;
// True if the page load started in the foreground.

Powered by Google App Engine
This is Rietveld 408576698