Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 1686643002: Add metric with time between background tab being foregrounded and the first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h" 5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h"
6 6
7 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 7 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
8 #include "components/page_load_metrics/common/page_load_timing.h" 8 #include "components/page_load_metrics/common/page_load_timing.h"
9 #include "content/public/browser/navigation_handle.h" 9 #include "content/public/browser/navigation_handle.h"
10 #include "net/base/stale_while_revalidate_experiment_domains.h" 10 #include "net/base/stale_while_revalidate_experiment_domains.h"
11 11
12 namespace chrome { 12 namespace chrome {
13 13
14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver() 14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver()
15 : is_interesting_domain_(false) {} 15 : is_interesting_domain_(false) {}
16 16
17 void StaleWhileRevalidateMetricsObserver::OnCommit( 17 void StaleWhileRevalidateMetricsObserver::OnCommit(
18 content::NavigationHandle* navigation_handle) { 18 content::NavigationHandle* navigation_handle) {
19 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain( 19 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain(
20 navigation_handle->GetURL().host()); 20 navigation_handle->GetURL().host());
21 } 21 }
22 22
23 void StaleWhileRevalidateMetricsObserver::OnComplete( 23 void StaleWhileRevalidateMetricsObserver::OnComplete(
24 const page_load_metrics::PageLoadTiming& timing, 24 const page_load_metrics::PageLoadTiming& timing,
25 const page_load_metrics::PageLoadExtraInfo& extra_info) { 25 const page_load_metrics::PageLoadExtraInfo& extra_info) {
26 using page_load_metrics::EventOccurredInForeground; 26 using page_load_metrics::WasStartedInForegroundEventInForeground;
27 27
28 if (!is_interesting_domain_) 28 if (!is_interesting_domain_)
29 return; 29 return;
30 30
31 if (EventOccurredInForeground(timing.load_event_start, extra_info)) { 31 if (WasStartedInForegroundEventInForeground(timing.load_event_start,
32 extra_info)) {
32 PAGE_LOAD_HISTOGRAM( 33 PAGE_LOAD_HISTOGRAM(
33 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 34 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
34 "NavigationToLoadEventFired", 35 "NavigationToLoadEventFired",
35 timing.load_event_start); 36 timing.load_event_start);
36 } 37 }
37 if (EventOccurredInForeground(timing.first_layout, extra_info)) { 38 if (WasStartedInForegroundEventInForeground(timing.first_layout,
39 extra_info)) {
38 PAGE_LOAD_HISTOGRAM( 40 PAGE_LOAD_HISTOGRAM(
39 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 41 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
40 "NavigationToFirstLayout", 42 "NavigationToFirstLayout",
41 timing.first_layout); 43 timing.first_layout);
42 } 44 }
43 if (EventOccurredInForeground(timing.first_text_paint, extra_info)) { 45 if (WasStartedInForegroundEventInForeground(timing.first_text_paint,
46 extra_info)) {
44 PAGE_LOAD_HISTOGRAM( 47 PAGE_LOAD_HISTOGRAM(
45 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 48 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
46 "NavigationToFirstTextPaint", 49 "NavigationToFirstTextPaint",
47 timing.first_text_paint); 50 timing.first_text_paint);
48 } 51 }
49 } 52 }
50 53
51 } // namespace chrome 54 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698