Use different SDKs based on option settings

We need to perform analysis differently based on some option settings (such as strong mode), but there is currently a single SDK that is shared across all contexts no matter which option values are being used. This causes us to inconsistently analyze different portions of the SDK depending on which outer context was the first to request the analysis.

This is at least a first step toward solving this problem by allowing multiple SDKs to be created, one for each unique set of options.

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/bdd0d637fed7b4bfc4004e08e9f9c8428c3e8022

[Brian Wilkerson, 2016-02-09 17:24:53]

Description was changed from

==========
Use different SDKs based on option settings
==========

to

==========
We need to perform analysis differently based on some option settings (such as
strong mode), but there is currently a single SDK that is shared across all
contexts no matter which option values are being used. This causes us to
inconsistently analyze different portions of the SDK depending on which outer
context was the first to request the analysis.

This is at least a first step toward solving this problem by allowing multiple
SDKs to be created, one for each unique set of options.
==========

[Brian Wilkerson, 2016-02-09 17:30:23]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Paul Berry, 2016-02-09 18:21:17]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2016-02-09 18:21:18]

lgtm

https://codereview.chromium.org/1686613002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/sdk.dart (right):

https://codereview.chromium.org/1686613002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/sdk.dart:88: * Manages the DartSdk's that
Incomplete comment

[scheglov, 2016-02-09 18:36:12]

LGTM

[Brian Wilkerson, 2016-02-09 19:05:38]

Description was changed from

==========
We need to perform analysis differently based on some option settings (such as
strong mode), but there is currently a single SDK that is shared across all
contexts no matter which option values are being used. This causes us to
inconsistently analyze different portions of the SDK depending on which outer
context was the first to request the analysis.

This is at least a first step toward solving this problem by allowing multiple
SDKs to be created, one for each unique set of options.
==========

to

==========
We need to perform analysis differently based on some option settings (such as
strong mode), but there is currently a single SDK that is shared across all
contexts no matter which option values are being used. This causes us to
inconsistently analyze different portions of the SDK depending on which outer
context was the first to request the analysis.

This is at least a first step toward solving this problem by allowing multiple
SDKs to be created, one for each unique set of options.

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bdd0d637fed7b4bfc4004e08e9f9c8428c3e8022
==========

[Brian Wilkerson, 2016-02-09 19:05:40]

Committed patchset #1 (id:1) manually as
bdd0d637fed7b4bfc4004e08e9f9c8428c3e8022 (presubmit successful).