tools/tests/skimage/input/README - Issue 16866010: skimage self-tests: confirm correctness of bitmap hash values

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/tests/skimage/input/README

Issue 16866010: skimage self-tests: confirm correctness of bitmap hash values (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: linewrap Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Resources needed for skimage self-tests go here.
	scroggo 2013/06/13 16:17:37 Need these resources be different from the top lev Need these resources be different from the top level resources? epoger 2013/06/13 16:24:47 A fair point. Initially, I hadn't even noticed th Show quoted text On 2013/06/13 16:17:37, scroggo wrote: > Need these resources be different from the top level resources? A fair point. Initially, I hadn't even noticed that this used images pulled from trunk/resources. Here's why I am doing this at all: I want to start using "skimage --createExpectationsPath" on the bots, to convert our expectations from images to JSON format. (See Step 1b in https://goto.google.com/ChecksumTransitionDetail ) Before I do that, I want to make sure that the skimage tool is correctly generating bitmap hashes from image files. Currently, the skimage self-test confirms that the bitmap hashes are generated CONSISTENTLY, but not that they are generated CORRECTLY. And having a particular set of input images (not shared with other tests, which may need their own images) for this test is key. Tell you what... I'm going to add more to this CL in a little bit... let's see if you think it looks good at that point.
OLD	NEW