Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1686563002: Relocate anisotropic mipmap logic to SkMipMap::extractLevel() (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Relocate anisotropic mipmap logic to SkMipMap::extractLevel() Pass a full x/y scale and defer the anisotropic heuristic to SkMipMap. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686563002 Committed: https://skia.googlesource.com/skia/+/33ed3ad9f62b3c84d439b92ab45732d4fa6d05ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M gm/showmiplevels.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapController.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M src/core/SkMipMap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M tests/MipMapTest.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
f(malita)
4 years, 10 months ago (2016-02-09 15:56:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686563002/1
4 years, 10 months ago (2016-02-09 15:57:02 UTC) #4
reed1
lgtm
4 years, 10 months ago (2016-02-09 15:59:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686563002/1
4 years, 10 months ago (2016-02-09 16:07:30 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 16:20:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/33ed3ad9f62b3c84d439b92ab45732d4fa6d05ad

Powered by Google App Engine
This is Rietveld 408576698