Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1686543003: skeleton for float <-> half optimized procs (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skeleton for float <-> half optimized procs Nothing fancy yet, just calls the serial code in a loop. I will try to folow this up with at least some of: - SSE2 version of serial code - NEON version of serial code - NEON version using vcvt.f32.f16/vcvt.f16.f32 - F16C (between AVX and AVX2) version using vcvtph2ps/vcvtps2ph The last two are fastest but need runtime detection. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686543003 Committed: https://skia.googlesource.com/skia/+/a525cb151bb39fb6362af051f69b6d633f660fd9

Patch Set 1 #

Patch Set 2 : add a test #

Patch Set 3 : npot #

Patch Set 4 : bench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
A bench/HalfBench.cpp View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkOpts.cpp View 3 chunks +17 lines, -0 lines 0 comments Download
M tests/Float16Test.cpp View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 10 months ago (2016-02-09 14:56:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686543003/40001
4 years, 10 months ago (2016-02-09 14:56:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686543003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686543003/60001
4 years, 10 months ago (2016-02-09 15:20:43 UTC) #7
reed1
lgtm
4 years, 10 months ago (2016-02-09 15:34:50 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 15:47:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686543003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686543003/60001
4 years, 10 months ago (2016-02-09 16:17:25 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 16:18:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a525cb151bb39fb6362af051f69b6d633f660fd9

Powered by Google App Engine
This is Rietveld 408576698