Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686533002: [interpreter] Enable exception tests that no longer fail. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Enable exception tests that no longer fail. R=rmcilroy@chromium.org Committed: https://crrev.com/e932c0e78812012ff632fd4571c297095c9cd04d Cr-Commit-Position: refs/heads/master@{#33846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M test/cctest/cctest.status View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Cannot reproduce locally, let's see what try-bots have to say. :)
4 years, 10 months ago (2016-02-09 12:28:00 UTC) #1
rmcilroy
LGTM, thanks!
4 years, 10 months ago (2016-02-09 12:43:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686533002/1
4 years, 10 months ago (2016-02-09 13:07:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 13:08:23 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 13:09:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e932c0e78812012ff632fd4571c297095c9cd04d
Cr-Commit-Position: refs/heads/master@{#33846}

Powered by Google App Engine
This is Rietveld 408576698