Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: Source/core/dom/Traversal.h

Issue 16865007: Make createNodeIterator() and createTreeWalker() accept default arguments. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use type tags in tests. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/NodeIterator.cpp ('k') | Source/core/dom/Traversal.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Traversal.h
diff --git a/Source/core/dom/Traversal.h b/Source/core/dom/Traversal.h
index 45cd76ee9b3c83306eb2b74d6d504b88594cf724..3e70886dcef259e9f64d8eb8ab73f65bfb996a95 100644
--- a/Source/core/dom/Traversal.h
+++ b/Source/core/dom/Traversal.h
@@ -38,17 +38,19 @@ namespace WebCore {
Node* root() const { return m_root.get(); }
unsigned whatToShow() const { return m_whatToShow; }
NodeFilter* filter() const { return m_filter.get(); }
- bool expandEntityReferences() const { return m_expandEntityReferences; }
+ // |expandEntityReferences| first appeared in "DOM Level 2 Traversal and Range". However, this argument was
+ // never implemented, and, in DOM4, the function argument |expandEntityReferences| is removed from
+ // Document.createNodeIterator() and Document.createTreeWalker().
+ bool expandEntityReferences() const { return false; }
protected:
- Traversal(PassRefPtr<Node>, unsigned whatToShow, PassRefPtr<NodeFilter>, bool expandEntityReferences);
+ Traversal(PassRefPtr<Node>, unsigned whatToShow, PassRefPtr<NodeFilter>);
short acceptNode(ScriptState*, Node*) const;
private:
RefPtr<Node> m_root;
unsigned m_whatToShow;
RefPtr<NodeFilter> m_filter;
- bool m_expandEntityReferences;
};
} // namespace WebCore
« no previous file with comments | « Source/core/dom/NodeIterator.cpp ('k') | Source/core/dom/Traversal.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698