Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: Source/core/dom/Document.idl

Issue 16865007: Make createNodeIterator() and createTreeWalker() accept default arguments. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use type tags in tests. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index 4e87c039624992e43355e38a07a96db26a9e4eb2..f61079d591626e251b7a027d9186fc6f6161c39a 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -65,20 +65,22 @@
[RaisesException] Event createEvent([Default=Undefined] optional DOMString eventType);
- // DOM Level 2 Tranversal and Range (DocumentRange interface)
+ // DOM Level 2 Traversal and Range (DocumentRange interface)
Range createRange();
- // DOM Level 2 Tranversal and Range (DocumentTraversal interface)
-
- [RaisesException] NodeIterator createNodeIterator([Default=Undefined] optional Node root,
- [Default=Undefined] optional unsigned long whatToShow,
- [Default=Undefined] optional NodeFilter filter,
- [Default=Undefined] optional boolean expandEntityReferences);
- [RaisesException] TreeWalker createTreeWalker([Default=Undefined] optional Node root,
- [Default=Undefined] optional unsigned long whatToShow,
- [Default=Undefined] optional NodeFilter filter,
- [Default=Undefined] optional boolean expandEntityReferences);
+ // DOM Level 2 Traversal and Range (DocumentTraversal interface)
+ // In DOM4, the fourth argument |expandEntityReferences| is removed.
+ // Historically, this argument was never implemented and has been ignored.
+ // We still receive the argument to keep compatibility, but don't do anything if it's specified.
+ [RaisesException] NodeIterator createNodeIterator(Node root,
+ optional unsigned long whatToShow,
+ optional NodeFilter filter,
+ optional boolean expandEntityReferences);
+ [RaisesException] TreeWalker createTreeWalker(Node root,
+ optional unsigned long whatToShow,
+ optional NodeFilter filter,
+ optional boolean expandEntityReferences);
// DOM Level 2 Abstract Views (DocumentView interface)
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeIterator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698