third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.cpp ('k') | third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

index 33f94403be364547e2705f44c893a2e3e340d73c..5f313ac02af2737be6d9a911200983400446c152 100644

--- a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

@@ -90,7 +90,7 @@ protected:

void executeScriptInIsolatedWorld(const String& script) const

{

v8::HandleScope scope(v8::Isolate::GetCurrent());

- WillBeHeapVector<ScriptSourceCode> sources;

+ HeapVector<ScriptSourceCode> sources;

sources.append(ScriptSourceCode(script));

Vector<v8::Local<v8::Value>> results;

m_scriptController->executeScriptInIsolatedWorld(isolatedWorldId, sources, extensionGroup, 0);

@@ -109,7 +109,7 @@ private:

static const int extensionGroup = 0;

WebViewHelper m_webViewHelper;

- RawPtrWillBePersistent<ScriptController> m_scriptController;

+ Persistent<ScriptController> m_scriptController;

// TestActivityLogger is owned by a static table within V8DOMActivityLogger

// and should be alive as long as not overwritten.

TestActivityLogger* m_activityLogger;