third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

index 389756e6f31c8b9fc6c3dfe3dbbadb506d87786e..605dc353c8e1cdc4bd4624f07bfca9e8c2842dcd 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

@@ -229,7 +229,7 @@ private:

// v8 guarantees that Blink will not regain control while a v8 GC runs

// (=> no Oilpan GCs will be triggered), hence raw, untraced members

// can safely be kept here.

- Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo;

+ Vector<UntracedMember<Node>> m_groupsWhichNeedRetainerInfo;

int m_domObjectsWithPendingActivity;

bool m_liveRootGroupIdSet;

bool m_constructRetainedObjectInfos;

@@ -480,7 +480,7 @@ public:

private:

v8::Isolate* m_isolate;

- RawPtrWillBePersistent<ExecutionContext> m_executionContext;

+ Persistent<ExecutionContext> m_executionContext;

bool m_pendingActivityFound;

};