third_party/WebKit/Source/core/frame/SmartClip.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/SmartClip.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/SmartClip.h ('k') | third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/SmartClip.cpp

diff --git a/third_party/WebKit/Source/core/frame/SmartClip.cpp b/third_party/WebKit/Source/core/frame/SmartClip.cpp

index db6f02a1c6798a79c8c0b8cd4735b9b43ed5e6bc..e4edf18e19d675e34b55db31e5a648b34343961d 100644

--- a/third_party/WebKit/Source/core/frame/SmartClip.cpp

+++ b/third_party/WebKit/Source/core/frame/SmartClip.cpp

@@ -69,7 +69,7 @@ const String& SmartClipData::clipData() const

return m_string;

}

-SmartClip::SmartClip(PassRefPtrWillBeRawPtr<LocalFrame> frame)

+SmartClip::SmartClip(RawPtr<LocalFrame> frame)

: m_frame(frame)

{

}

@@ -86,7 +86,7 @@ SmartClipData SmartClip::dataForRect(const IntRect& cropRectInViewport)

bestNode = bestNodeInFrame;

}

- WillBeHeapVector<RawPtrWillBeMember<Node>> hitNodes;

+ HeapVector<Member<Node>> hitNodes;

collectOverlappingChildNodes(bestNode, cropRectInViewport, hitNodes);

if (hitNodes.isEmpty() || hitNodes.size() == bestNode->countChildren()) {

@@ -214,7 +214,7 @@ bool SmartClip::shouldSkipBackgroundImage(Node* node)

return false;

}

-void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRectInViewport, WillBeHeapVector<RawPtrWillBeMember<Node>>& hitNodes)

+void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRectInViewport, HeapVector<Member<Node>>& hitNodes)

{

if (!parentNode)

return;