third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.h ('k') | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

index 7a634c9608328c73025ea32bb66fd541c825b3ef..f7696dfb8f2a42718a38b0f4d57cd0038b14137f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

@@ -125,7 +125,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,

return true;

}

-PassRefPtrWillBeRawPtr<CustomElementLifecycleCallbacks> CustomElementConstructorBuilder::createCallbacks()

+RawPtr<CustomElementLifecycleCallbacks> CustomElementConstructorBuilder::createCallbacks()

{

ASSERT(!m_prototype.IsEmpty());

@@ -282,7 +282,7 @@ static void constructCustomElement(const v8::FunctionCallbackInfo<v8::Value>& in

ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomElement", info.Holder(), info.GetIsolate());

CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;

- RefPtrWillBeRawPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);

+ RawPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);

if (exceptionState.throwIfNeeded())

return;

v8SetReturnValueFast(info, element.release(), document);