third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.h ('k') | third_party/WebKit/Source/core/css/parser/CSSParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

index ac2dba26b05606d2a132d2322591b632e602cc44..f78ba6ef4f4cd4304e88a7f930268b913ca1a720 100644

--- a/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

+++ b/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

@@ -38,7 +38,7 @@

namespace blink {

-StyleSheetInvalidationAnalysis::StyleSheetInvalidationAnalysis(const TreeScope& treeScope, const WillBeHeapVector<RawPtrWillBeMember<StyleSheetContents>>& sheets)

+StyleSheetInvalidationAnalysis::StyleSheetInvalidationAnalysis(const TreeScope& treeScope, const HeapVector<Member<StyleSheetContents>>& sheets)

: m_treeScope(&treeScope)

{

for (unsigned i = 0; i < sheets.size() && !m_dirtiesAllStyle; ++i)

@@ -112,7 +112,7 @@ void StyleSheetInvalidationAnalysis::analyzeStyleSheet(StyleSheetContents* style

// See if all rules on the sheet are scoped to some specific ids or classes.

// Then test if we actually have any of those in the tree at the moment.

- const WillBeHeapVector<RefPtrWillBeMember<StyleRuleImport>>& importRules = styleSheetContents->importRules();

+ const HeapVector<Member<StyleRuleImport>>& importRules = styleSheetContents->importRules();

for (unsigned i = 0; i < importRules.size(); ++i) {

if (!importRules[i]->styleSheet())

continue;

@@ -124,7 +124,7 @@ void StyleSheetInvalidationAnalysis::analyzeStyleSheet(StyleSheetContents* style

if (m_treeScope->rootNode().isShadowRoot())

return;

- const WillBeHeapVector<RefPtrWillBeMember<StyleRuleBase>>& rules = styleSheetContents->childRules();

+ const HeapVector<Member<StyleRuleBase>>& rules = styleSheetContents->childRules();

for (unsigned i = 0; i < rules.size(); i++) {

StyleRuleBase* rule = rules[i].get();

if (!rule->isStyleRule()) {