third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTitleElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

index f2ad8b49c796694e104ba9dc5a7826f853ee4d0d..93529b68a07debdec44d14427a5ff1cb3821ca3d 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

@@ -41,9 +41,9 @@ private:

OwnPtr<SpellCheckerClient> m_spellCheckerClient;

OwnPtr<DummyPageHolder> m_dummyPageHolder;

- RefPtrWillBePersistent<HTMLDocument> m_document;

- RefPtrWillBePersistent<HTMLTextFormControlElement> m_textControl;

- RefPtrWillBePersistent<HTMLInputElement> m_input;

+ Persistent<HTMLDocument> m_document;

+ Persistent<HTMLTextFormControlElement> m_textControl;

+ Persistent<HTMLInputElement> m_input;

};

class DummySpellCheckerClient : public EmptySpellCheckerClient {

@@ -207,7 +207,7 @@ TEST_F(HTMLTextFormControlElementTest, SpellCheckDoesNotCauseUpdateLayout)

document().frame()->selection().setSelection(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotUpdateAppearance);

ASSERT_EQ(3, input->selectionStart());

- OwnPtrWillBePersistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));

+ Persistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));

forceLayoutFlag();

int startCount = layoutCount();

spellChecker->respondToChangedSelection(oldSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);