third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/SurroundingText.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

index d591a6babd690bb74f6f6d226b85c32063f13bde..86817cfd96d62340f41e9dc9f68511115795aabd 100644

--- a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

@@ -17,13 +17,13 @@ TEST_F(VisiblePositionTest, ShadowV0DistributedNodes)

const char* bodyContent = "00112233";

const char* shadowContent = "<a>44<content select=#two></content>55<content select=#one></content>66</a>";

setBodyContent(bodyContent);

- RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");

+ RawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");

- RefPtrWillBeRawPtr<Element> body = document().body();

- RefPtrWillBeRawPtr<Element> one = body->querySelector("#one", ASSERT_NO_EXCEPTION);

- RefPtrWillBeRawPtr<Element> two = body->querySelector("#two", ASSERT_NO_EXCEPTION);

- RefPtrWillBeRawPtr<Element> four = shadowRoot->querySelector("#s4", ASSERT_NO_EXCEPTION);

- RefPtrWillBeRawPtr<Element> five = shadowRoot->querySelector("#s5", ASSERT_NO_EXCEPTION);

+ RawPtr<Element> body = document().body();

+ RawPtr<Element> one = body->querySelector("#one", ASSERT_NO_EXCEPTION);

+ RawPtr<Element> two = body->querySelector("#two", ASSERT_NO_EXCEPTION);

+ RawPtr<Element> four = shadowRoot->querySelector("#s4", ASSERT_NO_EXCEPTION);

+ RawPtr<Element> five = shadowRoot->querySelector("#s5", ASSERT_NO_EXCEPTION);

EXPECT_EQ(Position(one->firstChild(), 0), canonicalPositionOf(Position(one, 0)));

EXPECT_EQ(Position(one->firstChild(), 0), createVisiblePosition(Position(one, 0)).deepEquivalent());