third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLEmbedElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

index e2036484dfdd6bed87bb37d19b876913f215974d..57f1f86f6e205e88a88057dd5127f832cb1663f0 100644

--- a/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

@@ -44,9 +44,9 @@ inline HTMLEmbedElement::HTMLEmbedElement(Document& document, bool createdByPars

{

}

-PassRefPtrWillBeRawPtr<HTMLEmbedElement> HTMLEmbedElement::create(Document& document, bool createdByParser)

+RawPtr<HTMLEmbedElement> HTMLEmbedElement::create(Document& document, bool createdByParser)

{

- RefPtrWillBeRawPtr<HTMLEmbedElement> element = adoptRefWillBeNoop(new HTMLEmbedElement(document, createdByParser));

+ RawPtr<HTMLEmbedElement> element = new HTMLEmbedElement(document, createdByParser);

element->ensureUserAgentShadowRoot();

return element.release();

}

@@ -143,7 +143,7 @@ void HTMLEmbedElement::updateWidgetInternal()

Vector<String> paramValues;

parametersForPlugin(paramNames, paramValues);

- RefPtrWillBeRawPtr<HTMLEmbedElement> protect(this); // Loading the plugin might remove us from the document.

+ RawPtr<HTMLEmbedElement> protect(this); // Loading the plugin might remove us from the document.

// FIXME: Can we not have layoutObject here now that beforeload events are gone?

if (!layoutObject())