third_party/WebKit/Source/platform/LifecycleObserver.h - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleObserver.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/LifecycleNotifier.h ('k') | third_party/WebKit/Source/platform/MemoryPurgeController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/LifecycleObserver.h

diff --git a/third_party/WebKit/Source/platform/LifecycleObserver.h b/third_party/WebKit/Source/platform/LifecycleObserver.h

index 30c65bd12f74a3e7ecb33a8af31ae69b375f115c..09a9b3dc4d5b07b5309e79996c84a44b63697317 100644

--- a/third_party/WebKit/Source/platform/LifecycleObserver.h

+++ b/third_party/WebKit/Source/platform/LifecycleObserver.h

@@ -33,7 +33,7 @@

namespace blink {

template<typename T, typename Observer, typename Notifier>

-class LifecycleObserver : public WillBeGarbageCollectedMixin {

+class LifecycleObserver : public GarbageCollectedMixin {

public:

using Context = T;

@@ -44,7 +44,6 @@ public:

}

#endif

- EAGERLY_FINALIZE_WILL_BE_REMOVED();

DEFINE_INLINE_VIRTUAL_TRACE()

{

visitor->trace(m_lifecycleContext);

@@ -70,7 +69,7 @@ protected:

}

private:

- RawPtrWillBeWeakMember<Context> m_lifecycleContext;

+ WeakMember<Context> m_lifecycleContext;

};

template<typename T, typename Observer, typename Notifier>