Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
index a0d87428eebe77995e419e3c788a03316ae4bce4..f5b99490a856def9b49f970270e9f6b9e45b948e 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
@@ -75,10 +75,10 @@ ScriptValue IDBObjectStore::keyPath(ScriptState* scriptState) const
return ScriptValue::from(scriptState, m_metadata.keyPath);
}
-PassRefPtrWillBeRawPtr<DOMStringList> IDBObjectStore::indexNames() const
+RawPtr<DOMStringList> IDBObjectStore::indexNames() const
{
IDB_TRACE("IDBObjectStore::indexNames");
- RefPtrWillBeRawPtr<DOMStringList> indexNames = DOMStringList::create(DOMStringList::IndexedDB);
+ RawPtr<DOMStringList> indexNames = DOMStringList::create(DOMStringList::IndexedDB);
for (const auto& it : m_metadata.indexes)
indexNames->append(it.value.name);
indexNames->sort();
@@ -416,9 +416,9 @@ namespace {
// cursor success handlers are kept alive.
class IndexPopulator final : public EventListener {
public:
- static PassRefPtrWillBeRawPtr<IndexPopulator> create(ScriptState* scriptState, IDBDatabase* database, int64_t transactionId, int64_t objectStoreId, const IDBIndexMetadata& indexMetadata)
+ static RawPtr<IndexPopulator> create(ScriptState* scriptState, IDBDatabase* database, int64_t transactionId, int64_t objectStoreId, const IDBIndexMetadata& indexMetadata)
{
- return adoptRefWillBeNoop(new IndexPopulator(scriptState, database, transactionId, objectStoreId, indexMetadata));
+ return new IndexPopulator(scriptState, database, transactionId, objectStoreId, indexMetadata);
}
bool operator==(const EventListener& other) const override
@@ -483,7 +483,7 @@ private:
}
RefPtr<ScriptState> m_scriptState;
- PersistentWillBeMember<IDBDatabase> m_database;
+ Member<IDBDatabase> m_database;
const int64_t m_transactionId;
const int64_t m_objectStoreId;
const IDBIndexMetadata m_indexMetadata;
@@ -547,7 +547,7 @@ IDBIndex* IDBObjectStore::createIndex(ScriptState* scriptState, const String& na
indexRequest->preventPropagation();
// This is kept alive by being the success handler of the request, which is in turn kept alive by the owning transaction.
- RefPtrWillBeRawPtr<IndexPopulator> indexPopulator = IndexPopulator::create(scriptState, transaction()->db(), m_transaction->id(), id(), metadata);
+ RawPtr<IndexPopulator> indexPopulator = IndexPopulator::create(scriptState, transaction()->db(), m_transaction->id(), id(), metadata);
indexRequest->setOnsuccess(indexPopulator);
return index;
}

Powered by Google App Engine
This is Rietveld 408576698