Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
diff --git a/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp b/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
index 94d5715cd2ada04ca50b90e021b6792be94f2d97..3b51022644c1dacf33db06c31c2267b3f4b6e38d 100644
--- a/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
+++ b/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
@@ -42,15 +42,15 @@ namespace blink {
// accumulator for a given node even if there are multiple ChildListMutationScopes
// on the stack. The map is always empty when there are no ChildListMutationScopes
// on the stack.
-typedef WillBeHeapHashMap<RawPtrWillBeMember<Node>, RawPtrWillBeMember<ChildListMutationAccumulator>> AccumulatorMap;
+typedef HeapHashMap<Member<Node>, Member<ChildListMutationAccumulator>> AccumulatorMap;
static AccumulatorMap& accumulatorMap()
{
- DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<AccumulatorMap>, map, (adoptPtrWillBeNoop(new AccumulatorMap())));
+ DEFINE_STATIC_LOCAL(Persistent<AccumulatorMap>, map, (new AccumulatorMap()));
return *map;
}
-ChildListMutationAccumulator::ChildListMutationAccumulator(PassRefPtrWillBeRawPtr<Node> target, PassOwnPtrWillBeRawPtr<MutationObserverInterestGroup> observers)
+ChildListMutationAccumulator::ChildListMutationAccumulator(RawPtr<Node> target, RawPtr<MutationObserverInterestGroup> observers)
: m_target(target)
, m_lastAdded(nullptr)
, m_observers(observers)
@@ -68,16 +68,14 @@ void ChildListMutationAccumulator::leaveMutationScope()
}
}
-DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ChildListMutationAccumulator);
-
-PassRefPtrWillBeRawPtr<ChildListMutationAccumulator> ChildListMutationAccumulator::getOrCreate(Node& target)
+RawPtr<ChildListMutationAccumulator> ChildListMutationAccumulator::getOrCreate(Node& target)
{
AccumulatorMap::AddResult result = accumulatorMap().add(&target, nullptr);
- RefPtrWillBeRawPtr<ChildListMutationAccumulator> accumulator;
+ RawPtr<ChildListMutationAccumulator> accumulator;
if (!result.isNewEntry) {
accumulator = result.storedValue->value;
} else {
- accumulator = adoptRefWillBeNoop(new ChildListMutationAccumulator(PassRefPtrWillBeRawPtr<Node>(target), MutationObserverInterestGroup::createForChildListMutation(target)));
+ accumulator = new ChildListMutationAccumulator(RawPtr<Node>(target), MutationObserverInterestGroup::createForChildListMutation(target));
result.storedValue->value = accumulator.get();
}
return accumulator.release();
@@ -88,11 +86,11 @@ inline bool ChildListMutationAccumulator::isAddedNodeInOrder(Node* child)
return isEmpty() || (m_lastAdded == child->previousSibling() && m_nextSibling == child->nextSibling());
}
-void ChildListMutationAccumulator::childAdded(PassRefPtrWillBeRawPtr<Node> prpChild)
+void ChildListMutationAccumulator::childAdded(RawPtr<Node> prpChild)
{
ASSERT(hasObservers());
- RefPtrWillBeRawPtr<Node> child = prpChild;
+ RawPtr<Node> child = prpChild;
if (!isAddedNodeInOrder(child.get()))
enqueueMutationRecord();
@@ -111,11 +109,11 @@ inline bool ChildListMutationAccumulator::isRemovedNodeInOrder(Node* child)
return isEmpty() || m_nextSibling == child;
}
-void ChildListMutationAccumulator::willRemoveChild(PassRefPtrWillBeRawPtr<Node> prpChild)
+void ChildListMutationAccumulator::willRemoveChild(RawPtr<Node> prpChild)
{
ASSERT(hasObservers());
- RefPtrWillBeRawPtr<Node> child = prpChild;
+ RawPtr<Node> child = prpChild;
if (!m_addedNodes.isEmpty() || !isRemovedNodeInOrder(child.get()))
enqueueMutationRecord();
@@ -136,9 +134,9 @@ void ChildListMutationAccumulator::enqueueMutationRecord()
ASSERT(hasObservers());
ASSERT(!isEmpty());
- RefPtrWillBeRawPtr<StaticNodeList> addedNodes = StaticNodeList::adopt(m_addedNodes);
- RefPtrWillBeRawPtr<StaticNodeList> removedNodes = StaticNodeList::adopt(m_removedNodes);
- RefPtrWillBeRawPtr<MutationRecord> record = MutationRecord::createChildList(m_target, addedNodes.release(), removedNodes.release(), m_previousSibling.release(), m_nextSibling.release());
+ RawPtr<StaticNodeList> addedNodes = StaticNodeList::adopt(m_addedNodes);
+ RawPtr<StaticNodeList> removedNodes = StaticNodeList::adopt(m_removedNodes);
+ RawPtr<MutationRecord> record = MutationRecord::createChildList(m_target, addedNodes.release(), removedNodes.release(), m_previousSibling.release(), m_nextSibling.release());
m_observers->enqueueMutationRecord(record.release());
m_lastAdded = nullptr;
ASSERT(isEmpty());
« no previous file with comments | « third_party/WebKit/Source/core/dom/ChildListMutationScope.h ('k') | third_party/WebKit/Source/core/dom/ChildNodeList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698