third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/SplitElementCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

index fa3f458b2fc04581afb09b8e024b7361f1d0e8be..d2b43e7bd97e9cde627cb20a5bed5199ebdf8ad2 100644

--- a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

@@ -33,7 +33,7 @@

namespace blink {

-SplitElementCommand::SplitElementCommand(PassRefPtrWillBeRawPtr<Element> element, PassRefPtrWillBeRawPtr<Node> atChild)

+SplitElementCommand::SplitElementCommand(RawPtr<Element> element, RawPtr<Node> atChild)

: SimpleEditCommand(element->document())

, m_element2(element)

, m_atChild(atChild)

@@ -48,7 +48,7 @@ void SplitElementCommand::executeApply()

if (m_atChild->parentNode() != m_element2)

return;

- WillBeHeapVector<RefPtrWillBeMember<Node>> children;

+ HeapVector<Member<Node>> children;

for (Node* node = m_element2->firstChild(); node != m_atChild; node = node->nextSibling())

children.append(node);

@@ -83,7 +83,7 @@ void SplitElementCommand::doUnapply()

NodeVector children;

getChildNodes(*m_element1, children);

- RefPtrWillBeRawPtr<Node> refChild = m_element2->firstChild();

+ RawPtr<Node> refChild = m_element2->firstChild();

for (const auto& child : children)

m_element2->insertBefore(child.get(), refChild.get(), IGNORE_EXCEPTION);