third_party/WebKit/Source/core/css/PageRuleCollector.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/PageRuleCollector.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/PageRuleCollector.h ('k') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/PageRuleCollector.cpp

diff --git a/third_party/WebKit/Source/core/css/PageRuleCollector.cpp b/third_party/WebKit/Source/core/css/PageRuleCollector.cpp

index b7f11de04bb6a1c95d751eec96d109561cfe1c08..6e39d96bc5108ea9a0d3026e20546db6b4a6d371 100644

--- a/third_party/WebKit/Source/core/css/PageRuleCollector.cpp

+++ b/third_party/WebKit/Source/core/css/PageRuleCollector.cpp

@@ -73,7 +73,7 @@ void PageRuleCollector::matchPageRules(RuleSet* rules)

return;

rules->compactRulesIfNeeded();

- WillBeHeapVector<RawPtrWillBeMember<StyleRulePage>> matchedPageRules;

+ HeapVector<Member<StyleRulePage>> matchedPageRules;

matchPageRulesForList(matchedPageRules, rules->pageRules(), m_isLeftPage, m_isFirstPage, m_pageName);

if (matchedPageRules.isEmpty())

return;

@@ -104,7 +104,7 @@ static bool checkPageSelectorComponents(const CSSSelector* selector, bool isLeft

return true;

}

-void PageRuleCollector::matchPageRulesForList(WillBeHeapVector<RawPtrWillBeMember<StyleRulePage>>& matchedRules, const WillBeHeapVector<RawPtrWillBeMember<StyleRulePage>>& rules, bool isLeftPage, bool isFirstPage, const String& pageName)

+void PageRuleCollector::matchPageRulesForList(HeapVector<Member<StyleRulePage>>& matchedRules, const HeapVector<Member<StyleRulePage>>& rules, bool isLeftPage, bool isFirstPage, const String& pageName)

{

for (unsigned i = 0; i < rules.size(); ++i) {

StyleRulePage* rule = rules[i];