third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/AsyncOperationMap.h ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

index efcdb6d1c2db1b182a0b49439199bbedaef12ce5..b30b042a7f5da271b2b1e7caa90fdb98426ea040 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -118,13 +118,12 @@ namespace blink {

${forward_list}

-class CORE_EXPORT InstrumentingAgents : public RefCountedWillBeGarbageCollectedFinalized<InstrumentingAgents> {

+class CORE_EXPORT InstrumentingAgents : public GarbageCollectedFinalized<InstrumentingAgents> {

WTF_MAKE_NONCOPYABLE(InstrumentingAgents);

- USING_FAST_MALLOC_WILL_BE_REMOVED(InstrumentingAgents);

public:

- static PassRefPtrWillBeRawPtr<InstrumentingAgents> create()

+ static RawPtr<InstrumentingAgents> create()

{

- return adoptRefWillBeNoop(new InstrumentingAgents());

+ return new InstrumentingAgents();

}

~InstrumentingAgents() { }

DECLARE_TRACE();

@@ -465,7 +464,7 @@ def generate_instrumenting_agents(used_agents):

class_name=class_name,

getter_name=getter_name,

member_name=member_name))

- member_list.append(" RawPtrWillBeMember<%s> %s;" % (class_name, member_name))

+ member_list.append(" Member<%s> %s;" % (class_name, member_name))

init_list.append("%s(nullptr)" % member_name)

trace_list.append("visitor->trace(%s);" % member_name)

reset_list.append("%s = nullptr;" % member_name)