third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

index 44c6fd92e72a991fe899896183e4c44b6ba404ae..7abb0c5f056a4f95cc10d48cb50c5869904c5ee3 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

@@ -87,7 +87,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)

pos = positionOutsideTabSpan(pos);

- RefPtrWillBeRawPtr<Node> nodeToInsert = nullptr;

+ RawPtr<Node> nodeToInsert = nullptr;

if (shouldUseBreakElement(pos))

nodeToInsert = HTMLBRElement::create(document());

else

@@ -103,7 +103,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)

return;

if (needExtraLineBreak) {

- RefPtrWillBeRawPtr<Node> extraNode;

+ RawPtr<Node> extraNode;

// TODO(tkent): Can we remove HTMLTextFormControlElement dependency?

if (HTMLTextFormControlElement* textControl = enclosingTextFormControl(nodeToInsert.get()))

extraNode = textControl->createPlaceholderBreakElement();

@@ -159,7 +159,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)

if (textNode->inDocument()) {

insertTextIntoNode(textNode, 0, nonBreakingSpaceString());

} else {

- RefPtrWillBeRawPtr<Text> nbspNode = document().createTextNode(nonBreakingSpaceString());

+ RawPtr<Text> nbspNode = document().createTextNode(nonBreakingSpaceString());

insertNodeAt(nbspNode.get(), positionBeforeTextNode, editingState);

if (editingState->isAborted())

return;

@@ -172,7 +172,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)

// Handle the case where there is a typing style.

- RefPtrWillBeRawPtr<EditingStyle> typingStyle = document().frame()->selection().typingStyle();

+ RawPtr<EditingStyle> typingStyle = document().frame()->selection().typingStyle();

if (typingStyle && !typingStyle->isEmpty()) {

// Apply the typing style to the inserted line break, so that if the selection