third_party/WebKit/Source/web/WebHelperPluginImpl.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/web/WebHelperPluginImpl.h ('k') | third_party/WebKit/Source/web/WebHistoryItem.cpp » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

index c14111aa202de6628df29452f46fcde89e4a87c3..70500046555d6bccc951106f74652433adfc31e9 100644

--- a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

+++ b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

@@ -76,7 +76,7 @@ bool WebHelperPluginImpl::initialize(const String& pluginType, WebLocalFrameImpl

Vector<String> attributeNames;

Vector<String> attributeValues;

ASSERT(frame->frame()->document()->url().isValid());

- m_pluginContainer = adoptRefWillBeNoop(toWebPluginContainerImpl(frame->frame()->loader().client()->createPlugin(

+ m_pluginContainer = (toWebPluginContainerImpl(frame->frame()->loader().client()->createPlugin(

m_objectElement.get(),

frame->frame()->document()->url(),

attributeNames,