Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
index a09c6707046e34edadc476c3c5790a4a56f06f03..13c8fe40f0f3c273de57b1355568dcbcb02ceea4 100644
--- a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
+++ b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
@@ -26,10 +26,9 @@
namespace blink {
-class RadioButtonGroup : public NoBaseWillBeGarbageCollected<RadioButtonGroup> {
- USING_FAST_MALLOC_WILL_BE_REMOVED(RadioButtonGroup);
+class RadioButtonGroup : public GarbageCollected<RadioButtonGroup> {
public:
- static PassOwnPtrWillBeRawPtr<RadioButtonGroup> create();
+ static RawPtr<RadioButtonGroup> create();
bool isEmpty() const { return m_members.isEmpty(); }
bool isRequired() const { return m_requiredCount; }
HTMLInputElement* checkedButton() const { return m_checkedButton; }
@@ -48,7 +47,7 @@ private:
void setCheckedButton(HTMLInputElement*);
// The map records the 'required' state of each (button) element.
- using Members = WillBeHeapHashMap<RawPtrWillBeMember<HTMLInputElement>, bool>;
+ using Members = HeapHashMap<Member<HTMLInputElement>, bool>;
#if ENABLE(OILPAN)
using MemberKeyValue = WTF::KeyValuePair<Member<HTMLInputElement>, bool>;
@@ -59,7 +58,7 @@ private:
void updateRequiredButton(MemberKeyValue&, bool isRequired);
Members m_members;
- RawPtrWillBeMember<HTMLInputElement> m_checkedButton;
+ Member<HTMLInputElement> m_checkedButton;
size_t m_requiredCount;
};
@@ -69,9 +68,9 @@ RadioButtonGroup::RadioButtonGroup()
{
}
-PassOwnPtrWillBeRawPtr<RadioButtonGroup> RadioButtonGroup::create()
+RawPtr<RadioButtonGroup> RadioButtonGroup::create()
{
- return adoptPtrWillBeNoop(new RadioButtonGroup);
+ return (new RadioButtonGroup);
}
inline bool RadioButtonGroup::isValid() const
@@ -224,9 +223,9 @@ void RadioButtonGroupScope::addButton(HTMLInputElement* element)
return;
if (!m_nameToGroupMap)
- m_nameToGroupMap = adoptPtrWillBeNoop(new NameToGroupMap);
+ m_nameToGroupMap = (new NameToGroupMap);
- OwnPtrWillBeMember<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name(), nullptr).storedValue->value;
+ Member<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name(), nullptr).storedValue->value;
if (!group)
group = RadioButtonGroup::create();
group->add(element);

Powered by Google App Engine
This is Rietveld 408576698