third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/dom/ContextFeatures.h ('k') | third_party/WebKit/Source/core/dom/DOMImplementation.h » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

index 840b2fc1d58853fa78b2eb5a575e41f85faee1af..683ad3e70c33a5f292eee3b23665ca69a20d36ec 100644

--- a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

@@ -35,7 +35,7 @@ namespace blink {

void ContextLifecycleNotifier::notifyResumingActiveDOMObjects()

{

TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- Vector<RawPtrWillBeUntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

+ Vector<UntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

copyToVector(m_observers, snapshotOfObservers);

for (ContextLifecycleObserver* observer : snapshotOfObservers) {

// FIXME: Oilpan: At the moment, it's possible that a ActiveDOMObject

@@ -58,7 +58,7 @@ void ContextLifecycleNotifier::notifyResumingActiveDOMObjects()

void ContextLifecycleNotifier::notifySuspendingActiveDOMObjects()

{

TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- Vector<RawPtrWillBeUntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

+ Vector<UntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

copyToVector(m_observers, snapshotOfObservers);

for (ContextLifecycleObserver* observer : snapshotOfObservers) {

// It's possible that the ActiveDOMObject is already destructed.

@@ -77,7 +77,7 @@ void ContextLifecycleNotifier::notifySuspendingActiveDOMObjects()

void ContextLifecycleNotifier::notifyStoppingActiveDOMObjects()

{

TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- Vector<RawPtrWillBeUntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

+ Vector<UntracedMember<ContextLifecycleObserver>> snapshotOfObservers;

copyToVector(m_observers, snapshotOfObservers);

for (ContextLifecycleObserver* observer : snapshotOfObservers) {

// It's possible that the ActiveDOMObject is already destructed.