third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.h ('k') | third_party/WebKit/Source/core/frame/Frame.h » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

index b889e6cab12db1871bb7de93baf527fb4d1cfa12..8129a19b364dc05f9a756e8d762cdc43eb1cde19 100644

--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

@@ -246,7 +246,7 @@ DEFINE_TRACE(EventHandlerRegistry)

void EventHandlerRegistry::clearWeakMembers(Visitor* visitor)

{

- Vector<RawPtrWillBeUntracedMember<EventTarget>> deadTargets;

+ Vector<UntracedMember<EventTarget>> deadTargets;

for (size_t i = 0; i < EventHandlerClassCount; ++i) {

EventHandlerClass handlerClass = static_cast<EventHandlerClass>(i);

const EventTargetSet* targets = &m_targets[handlerClass];

@@ -269,7 +269,7 @@ void EventHandlerRegistry::documentDetached(Document& document)

// Remove all event targets under the detached document.

for (size_t handlerClassIndex = 0; handlerClassIndex < EventHandlerClassCount; ++handlerClassIndex) {

EventHandlerClass handlerClass = static_cast<EventHandlerClass>(handlerClassIndex);

- Vector<RawPtrWillBeUntracedMember<EventTarget>> targetsToRemove;

+ Vector<UntracedMember<EventTarget>> targetsToRemove;

const EventTargetSet* targets = &m_targets[handlerClass];

for (const auto& eventTarget : *targets) {

if (Node* node = eventTarget.key->toNode()) {