Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
diff --git a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
index 2aabde5f091cd2e9a1afeb43d6448a4a66895e6d..fefbe341bb616d6668bdaef6f049c540d82dfc9e 100644
--- a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
+++ b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
@@ -181,9 +181,9 @@ TEST(
// SVG animation attributes.
TEST(UnsafeSVGAttributeSanitizationTest, stringsShouldNotSupportAddition)
{
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<SVGElement> target = SVGAElement::create(*document);
- RefPtrWillBeRawPtr<SVGAnimateElement> element = SVGAnimateElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<SVGElement> target = SVGAElement::create(*document);
+ RawPtr<SVGAnimateElement> element = SVGAnimateElement::create(*document);
element->setTargetElement(target.get());
element->setAttributeName(XLinkNames::hrefAttr);
@@ -202,8 +202,8 @@ TEST(
attributes.append(Attribute(SVGNames::fromAttr, "/home"));
attributes.append(Attribute(SVGNames::toAttr, "javascript:own3d()"));
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGAnimateElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGAnimateElement::create(*document);
element->stripScriptingAttributes(attributes);
EXPECT_EQ(2ul, attributes.size()) <<
@@ -221,8 +221,8 @@ TEST(
isJavaScriptURLAttribute_xlinkHrefContainingJavascriptURL)
{
Attribute attribute(XLinkNames::hrefAttr, "javascript:alert()");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGAElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGAElement::create(*document);
EXPECT_TRUE(
element->isJavaScriptURLAttribute(attribute)) <<
"The 'a' element should identify an 'xlink:href' attribute with a "
@@ -236,8 +236,8 @@ TEST(
QualifiedName hrefAlternatePrefix(
"foo", "href", XLinkNames::xlinkNamespaceURI);
Attribute evilAttribute(hrefAlternatePrefix, "javascript:alert()");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGAElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGAElement::create(*document);
EXPECT_TRUE(element->isJavaScriptURLAttribute(evilAttribute)) <<
"The XLink 'href' attribute with a JavaScript URL value should be "
"identified as a JavaScript URL attribute, even if the attribute "
@@ -249,8 +249,8 @@ TEST(
isSVGAnimationAttributeSettingJavaScriptURL_fromContainingJavaScriptURL)
{
Attribute evilAttribute(SVGNames::fromAttr, "javascript:alert()");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGAnimateElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGAnimateElement::create(*document);
EXPECT_TRUE(
element->isSVGAnimationAttributeSettingJavaScriptURL(evilAttribute)) <<
"The animate element should identify a 'from' attribute with a "
@@ -262,8 +262,8 @@ TEST(
isSVGAnimationAttributeSettingJavaScriptURL_toContainingJavaScripURL)
{
Attribute evilAttribute(SVGNames::toAttr, "javascript:window.close()");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGSetElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGSetElement::create(*document);
EXPECT_TRUE(
element->isSVGAnimationAttributeSettingJavaScriptURL(evilAttribute)) <<
"The set element should identify a 'to' attribute with a JavaScript "
@@ -275,8 +275,8 @@ TEST(
isSVGAnimationAttributeSettingJavaScriptURL_valuesContainingJavaScriptURL)
{
Attribute evilAttribute(SVGNames::valuesAttr, "hi!; javascript:confirm()");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGAnimateElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGAnimateElement::create(*document);
element = SVGAnimateElement::create(*document);
EXPECT_TRUE(
element->isSVGAnimationAttributeSettingJavaScriptURL(evilAttribute)) <<
@@ -289,8 +289,8 @@ TEST(
isSVGAnimationAttributeSettingJavaScriptURL_innocuousAnimationAttribute)
{
Attribute fineAttribute(SVGNames::fromAttr, "hello, world!");
- RefPtrWillBeRawPtr<Document> document = Document::create();
- RefPtrWillBeRawPtr<Element> element = SVGSetElement::create(*document);
+ RawPtr<Document> document = Document::create();
+ RawPtr<Element> element = SVGSetElement::create(*document);
EXPECT_FALSE(
element->isSVGAnimationAttributeSettingJavaScriptURL(fineAttribute)) <<
"The animate element should not identify a 'from' attribute with an "

Powered by Google App Engine
This is Rietveld 408576698