Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StyleEngine.h
diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.h b/third_party/WebKit/Source/core/dom/StyleEngine.h
index 8b1f7cc7a71543bf64058ed01c05b3591cea8e77..f0deb9295a44023453fe93b062dfb477d1570096 100644
--- a/third_party/WebKit/Source/core/dom/StyleEngine.h
+++ b/third_party/WebKit/Source/core/dom/StyleEngine.h
@@ -55,9 +55,8 @@ class StyleRuleFontFace;
class StyleSheet;
class StyleSheetContents;
-class CORE_EXPORT StyleEngine final : public NoBaseWillBeGarbageCollectedFinalized<StyleEngine>, public CSSFontSelectorClient {
- USING_FAST_MALLOC_WILL_BE_REMOVED(StyleEngine);
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(StyleEngine);
+class CORE_EXPORT StyleEngine final : public GarbageCollectedFinalized<StyleEngine>, public CSSFontSelectorClient {
+ USING_GARBAGE_COLLECTED_MIXIN(StyleEngine);
public:
class IgnoringPendingStylesheet : public TemporaryChange<bool> {
@@ -71,7 +70,7 @@ public:
friend class IgnoringPendingStylesheet;
- static PassOwnPtrWillBeRawPtr<StyleEngine> create(Document& document) { return adoptPtrWillBeNoop(new StyleEngine(document)); }
+ static RawPtr<StyleEngine> create(Document& document) { return (new StyleEngine(document)); }
~StyleEngine();
@@ -79,11 +78,11 @@ public:
void detachFromDocument();
#endif
- const WillBeHeapVector<RefPtrWillBeMember<StyleSheet>>& styleSheetsForStyleSheetList(TreeScope&);
+ const HeapVector<Member<StyleSheet>>& styleSheetsForStyleSheetList(TreeScope&);
- const WillBeHeapVector<RefPtrWillBeMember<CSSStyleSheet>>& injectedAuthorStyleSheets() const { return m_injectedAuthorStyleSheets; }
+ const HeapVector<Member<CSSStyleSheet>>& injectedAuthorStyleSheets() const { return m_injectedAuthorStyleSheets; }
- const WillBeHeapVector<RefPtrWillBeMember<CSSStyleSheet>> activeStyleSheetsForInspector() const;
+ const HeapVector<Member<CSSStyleSheet>> activeStyleSheetsForInspector() const;
void modifiedStyleSheet(StyleSheet*);
void addStyleSheetCandidateNode(Node*, bool createdByParser);
@@ -91,7 +90,7 @@ public:
void removeStyleSheetCandidateNode(Node*, TreeScope&);
void modifiedStyleSheetCandidateNode(Node*);
- void injectAuthorSheet(PassRefPtrWillBeRawPtr<StyleSheetContents> authorSheet);
+ void injectAuthorSheet(RawPtr<StyleSheetContents> authorSheet);
void clearMediaQueryRuleSetStyleSheets();
void updateStyleSheetsInImport(DocumentStyleSheetCollector& parentCollector);
@@ -152,9 +151,9 @@ public:
StyleInvalidator& styleInvalidator() { return m_styleInvalidator; }
CSSFontSelector* fontSelector() { return m_fontSelector.get(); }
- void setFontSelector(PassRefPtrWillBeRawPtr<CSSFontSelector>);
+ void setFontSelector(RawPtr<CSSFontSelector>);
- void removeFontFaceRules(const WillBeHeapVector<RawPtrWillBeMember<const StyleRuleFontFace>>&);
+ void removeFontFaceRules(const HeapVector<Member<const StyleRuleFontFace>>&);
void clearFontCache();
// updateGenericFontFamilySettings is used from WebSettingsImpl.
void updateGenericFontFamilySettings();
@@ -165,7 +164,7 @@ public:
void markDocumentDirty();
- PassRefPtrWillBeRawPtr<CSSStyleSheet> createSheet(Element*, const String& text, TextPosition startPosition);
+ RawPtr<CSSStyleSheet> createSheet(Element*, const String& text, TextPosition startPosition);
void removeSheet(StyleSheetContents*);
void collectScopedStyleFeaturesTo(RuleFeatureSet&) const;
@@ -204,13 +203,13 @@ private:
Document* master();
Document& document() const { return *m_document; }
- typedef WillBeHeapHashSet<RawPtrWillBeMember<TreeScope>> UnorderedTreeScopeSet;
+ typedef HeapHashSet<Member<TreeScope>> UnorderedTreeScopeSet;
void clearMediaQueryRuleSetOnTreeScopeStyleSheets(UnorderedTreeScopeSet&);
void createResolver();
- static PassRefPtrWillBeRawPtr<CSSStyleSheet> parseSheet(Element*, const String& text, TextPosition startPosition);
+ static RawPtr<CSSStyleSheet> parseSheet(Element*, const String& text, TextPosition startPosition);
const DocumentStyleSheetCollection* documentStyleSheetCollection() const
{
@@ -226,7 +225,7 @@ private:
bool shouldSkipInvalidationFor(const Element&) const;
- RawPtrWillBeMember<Document> m_document;
+ Member<Document> m_document;
bool m_isMaster;
// Track the number of currently loading top-level stylesheets needed for layout.
@@ -235,11 +234,11 @@ private:
// elements and when it is safe to execute scripts.
int m_pendingStylesheets = 0;
- WillBeHeapVector<RefPtrWillBeMember<CSSStyleSheet>> m_injectedAuthorStyleSheets;
+ HeapVector<Member<CSSStyleSheet>> m_injectedAuthorStyleSheets;
- OwnPtrWillBeMember<DocumentStyleSheetCollection> m_documentStyleSheetCollection;
+ Member<DocumentStyleSheetCollection> m_documentStyleSheetCollection;
- typedef WillBeHeapHashMap<RawPtrWillBeWeakMember<TreeScope>, OwnPtrWillBeMember<ShadowTreeStyleSheetCollection>> StyleSheetCollectionMap;
+ typedef HeapHashMap<WeakMember<TreeScope>, Member<ShadowTreeStyleSheetCollection>> StyleSheetCollectionMap;
StyleSheetCollectionMap m_styleSheetCollectionMap;
bool m_documentScopeDirty = true;
@@ -257,13 +256,13 @@ private:
bool m_ignorePendingStylesheets = false;
bool m_didCalculateResolver = false;
- OwnPtrWillBeMember<StyleResolver> m_resolver;
+ Member<StyleResolver> m_resolver;
StyleInvalidator m_styleInvalidator;
- RefPtrWillBeMember<CSSFontSelector> m_fontSelector;
+ Member<CSSFontSelector> m_fontSelector;
- WillBeHeapHashMap<AtomicString, RawPtrWillBeMember<StyleSheetContents>> m_textToSheetCache;
- WillBeHeapHashMap<RawPtrWillBeMember<StyleSheetContents>, AtomicString> m_sheetToTextCache;
+ HeapHashMap<AtomicString, Member<StyleSheetContents>> m_textToSheetCache;
+ HeapHashMap<Member<StyleSheetContents>, AtomicString> m_sheetToTextCache;
OwnPtr<StyleResolverStats> m_styleResolverStats;
unsigned m_styleForElementCount = 0;

Powered by Google App Engine
This is Rietveld 408576698