Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
index e1244a6d7646af70915ed3be252185d118812004..dfbef8dba20dccb22e58574b4181917ee7bb68ff 100644
--- a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
@@ -18,12 +18,12 @@
namespace blink {
-class MockLinkLoaderClient final : public NoBaseWillBeGarbageCollectedFinalized<MockLinkLoaderClient>, public LinkLoaderClient {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MockLinkLoaderClient);
+class MockLinkLoaderClient final : public GarbageCollectedFinalized<MockLinkLoaderClient>, public LinkLoaderClient {
+ USING_GARBAGE_COLLECTED_MIXIN(MockLinkLoaderClient);
public:
- static PassOwnPtrWillBeRawPtr<MockLinkLoaderClient> create(bool shouldLoad)
+ static RawPtr<MockLinkLoaderClient> create(bool shouldLoad)
{
- return adoptPtrWillBeNoop(new MockLinkLoaderClient(shouldLoad));
+ return (new MockLinkLoaderClient(shouldLoad));
}
DEFINE_INLINE_VIRTUAL_TRACE() { LinkLoaderClient::trace(visitor); }
@@ -110,8 +110,8 @@ TEST(LinkLoaderTest, Preload)
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->frame().settings()->setScriptEnabled(true);
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(), testCase.href);
loader->loadLink(LinkRelAttribute("preload"),
CrossOriginAttributeNotSet,
@@ -121,7 +121,7 @@ TEST(LinkLoaderTest, Preload)
dummyPageHolder->document(),
NetworkHintsMock());
ASSERT(dummyPageHolder->document().fetcher());
- WillBeHeapListHashSet<RefPtrWillBeMember<Resource>>* preloads = dummyPageHolder->document().fetcher()->preloads();
+ HeapListHashSet<Member<Resource>>* preloads = dummyPageHolder->document().fetcher()->preloads();
if (testCase.shouldLoad)
ASSERT_NE(nullptr, preloads);
if (preloads) {
@@ -159,8 +159,8 @@ TEST(LinkLoaderTest, DNSPrefetch)
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true);
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
loader->loadLink(LinkRelAttribute("dns-prefetch"),
@@ -193,8 +193,8 @@ TEST(LinkLoaderTest, Preconnect)
// Test the cases with a single header
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
- OwnPtrWillBePersistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
- OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
+ Persistent<MockLinkLoaderClient> loaderClient = MockLinkLoaderClient::create(testCase.shouldLoad);
+ RawPtr<LinkLoader> loader = LinkLoader::create(loaderClient.get());
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
loader->loadLink(LinkRelAttribute("preconnect"),

Powered by Google App Engine
This is Rietveld 408576698