third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollState.idl ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp

index 6c7a1a90053f5a78cc65b3f43dfb4815254d765b..8e93552725abeb02f1b4eeaf7e8532645c9500d3 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp

@@ -21,7 +21,7 @@ TEST_F(ScrollStateTest, ConsumeDeltaNative)

const float deltaXToConsume = 1.2;

const float deltaYToConsume = 2.3;

- RefPtrWillBeRawPtr<ScrollState> scrollState = ScrollState::create(deltaX, deltaY, 0, 0, 0, false, false);

+ RawPtr<ScrollState> scrollState = ScrollState::create(deltaX, deltaY, 0, 0, 0, false, false);

EXPECT_FLOAT_EQ(deltaX, scrollState->deltaX());

EXPECT_FLOAT_EQ(deltaY, scrollState->deltaY());

EXPECT_FALSE(scrollState->deltaConsumedForScrollSequence());

@@ -52,9 +52,9 @@ TEST_F(ScrollStateTest, ConsumeDeltaNative)

TEST_F(ScrollStateTest, CurrentNativeScrollingElement)

{

- RefPtrWillBeRawPtr<ScrollState> scrollState =

+ RawPtr<ScrollState> scrollState =

ScrollState::create(0, 0, 0, 0, 0, false, false);

- RefPtrWillBeRawPtr<Element> element = Element::create(

+ RawPtr<Element> element = Element::create(

QualifiedName::null(), Document::create().get());

scrollState->setCurrentNativeScrollingElement(element.get());

@@ -63,11 +63,11 @@ TEST_F(ScrollStateTest, CurrentNativeScrollingElement)

TEST_F(ScrollStateTest, FullyConsumed)

{

- RefPtrWillBeRawPtr<ScrollState> scrollStateBegin =

+ RawPtr<ScrollState> scrollStateBegin =

ScrollState::create(0, 0, 0, 0, 0, false, true, false);

- RefPtrWillBeRawPtr<ScrollState> scrollState =

+ RawPtr<ScrollState> scrollState =

ScrollState::create(0, 0, 0, 0, 0, false, false, false);

- RefPtrWillBeRawPtr<ScrollState> scrollStateEnd =

+ RawPtr<ScrollState> scrollStateEnd =

ScrollState::create(0, 0, 0, 0, 0, false, false, true);

EXPECT_FALSE(scrollStateBegin->fullyConsumed());

EXPECT_TRUE(scrollState->fullyConsumed());