Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index fb1f31fe4a687103d510adff2a989b614d419429..acf53d5401a8d423b2ae52bb2f0dd80b20e5885c 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -59,9 +59,8 @@ class SharedBuffer;
// A resource that is held in the cache. Classes who want to use this object should derive
// from ResourceClient, to get the function calls in case the requested data has arrived.
// This class also does the actual communication with the loader to obtain the resource from the network.
-class CORE_EXPORT Resource : public RefCountedWillBeGarbageCollectedFinalized<Resource> {
+class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource> {
WTF_MAKE_NONCOPYABLE(Resource);
- USING_FAST_MALLOC_WITH_TYPE_NAME_WILL_BE_REMOVED(blink::Resource);
friend class InspectorResource;
public:
@@ -91,9 +90,9 @@ public:
};
// Exposed for testing.
- static PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, Type type)
+ static RawPtr<Resource> create(const ResourceRequest& request, Type type)
{
- return adoptRefWillBeNoop(new Resource(request, type));
+ return (new Resource(request, type));
}
virtual ~Resource();
@@ -256,7 +255,7 @@ public:
static const char* resourceTypeName(Type);
// TODO(japhet): Remove once oilpan ships, it doesn't need the WeakPtr.
- WeakPtrWillBeRawPtr<Resource> asWeakPtr();
+ RawPtr<Resource> asWeakPtr();
#ifdef ENABLE_RESOURCE_IS_DELETED_CHECK
void assertAlive() const { RELEASE_ASSERT(!m_deleted); }
@@ -282,7 +281,7 @@ protected:
HashCountedSet<ResourceClient*> m_clientsAwaitingCallback;
HashCountedSet<ResourceClient*> m_finishedClients;
- class ResourceCallback : public NoBaseWillBeGarbageCollectedFinalized<ResourceCallback> {
+ class ResourceCallback : public GarbageCollectedFinalized<ResourceCallback> {
public:
static ResourceCallback* callbackHandler();
DECLARE_TRACE();
@@ -293,7 +292,7 @@ protected:
ResourceCallback();
void runTask();
OwnPtr<CancellableTaskFactory> m_callbackTaskFactory;
- WillBeHeapHashSet<RefPtrWillBeMember<Resource>> m_resourcesWithPendingClients;
+ HeapHashSet<Member<Resource>> m_resourcesWithPendingClients;
};
bool hasClient(ResourceClient* client) { return m_clients.contains(client) || m_clientsAwaitingCallback.contains(client) || m_finishedClients.contains(client); }
@@ -323,7 +322,7 @@ protected:
ResourceRequest m_resourceRequest;
ResourceRequest m_revalidatingRequest;
AtomicString m_accept;
- PersistentWillBeMember<ResourceLoader> m_loader;
+ Member<ResourceLoader> m_loader;
ResourceLoaderOptions m_options;
ResourceResponse m_response;
@@ -353,7 +352,7 @@ private:
#endif
RefPtr<CachedMetadata> m_cachedMetadata;
- OwnPtrWillBeMember<CacheHandler> m_cacheHandler;
+ Member<CacheHandler> m_cacheHandler;
ResourceError m_error;
@@ -389,7 +388,7 @@ private:
class ResourceFactory {
STACK_ALLOCATED();
public:
- virtual PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest&, const String&) const = 0;
+ virtual RawPtr<Resource> create(const ResourceRequest&, const String&) const = 0;
Resource::Type type() const { return m_type; }
protected:
@@ -400,7 +399,7 @@ protected:
#define DEFINE_RESOURCE_TYPE_CASTS(typeName) \
DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, resource->type() == Resource::typeName, resource.type() == Resource::typeName); \
- inline typeName##Resource* to##typeName##Resource(const RefPtrWillBeRawPtr<Resource>& ptr) { return to##typeName##Resource(ptr.get()); }
+ inline typeName##Resource* to##typeName##Resource(const RawPtr<Resource>& ptr) { return to##typeName##Resource(ptr.get()); }
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698